Page MenuHomePhabricator

Add Scalastyle linter
Needs ReviewPublic

Authored by onur.cakmak on Sep 23 2015, 5:09 PM.

Details

Summary

A scalastyle linter that we have been testing internally for some time.
The implementation doesn't depend on sbt or a wrapper script.

Test Plan

Add a scalastyle linter with a configuration pointing to the scalastyle files and break a scalastyle rule.

Example configuration:

.arclint
{
  "linters": {
    "scalastyle": {
      "type": "scalastyle",
      "scalastyle.config": "support/scalastyle/scalastyle-config.xml",
      "scalastyle.jar": "support/scalastyle/scalastyle_2.11-0.6.0-batch.jar",
      "include": "(\\.scala$)"
    }
  }
}

Diff Detail

Repository
rARC Arcanist
Branch
feature-scalastyle
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 8039
Build 9110: [Placeholder Plan] Wait for 30 Seconds
Build 9109: arc lint + arc unit

Event Timeline

onur.cakmak retitled this revision from to Add Scalastyle linter.
onur.cakmak updated this object.
onur.cakmak edited the test plan for this revision. (Show Details)
onur.cakmak added a reviewer: epriestley.
onur.cakmak edited edge metadata.
  • Fix pht string formats

You will want to add some tests inside https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/__tests__/ to ensure future changes don't break current functionality.