Page MenuHomePhabricator

Recover gracefully from Conduit failure when building "Tags" field in commit mail
ClosedPublic

Authored by epriestley on Sep 22 2015, 7:59 PM.
Tags
None
Referenced Files
F13966231: D14142.diff
Wed, Oct 16, 7:04 AM
Unknown Object (File)
Mon, Sep 23, 2:22 PM
Unknown Object (File)
Mon, Sep 23, 2:20 PM
Unknown Object (File)
Mon, Sep 23, 2:19 PM
Unknown Object (File)
Mon, Sep 23, 2:17 PM
Unknown Object (File)
Sep 6 2024, 2:28 PM
Unknown Object (File)
Sep 5 2024, 4:27 PM
Unknown Object (File)
Sep 5 2024, 4:27 PM
Subscribers
None

Details

Summary

Ref T9458. This is basically the same as D13319, but the "Tags" field didn't get covered in that change.

Specifically, the issue is:

  • We try to generate mail to a disabled user (later, we'll drop it without delivering it, but that filtering doesn't happen yet).
  • The disabled user doesn't have permission to use Conduit (or any other Conduit-related problem occurs).
  • We fail here, then retry generating the mail again later.

Instead, just degrade to not building the field and showing what went wrong.

Test Plan
  • Pushed some commits, saw mail generate.
  • Added a fake exception to the field, saw the mail generate with an error message.

Diff Detail

Repository
rP Phabricator
Branch
tagsfield1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8026
Build 9082: [Placeholder Plan] Wait for 30 Seconds
Build 9081: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Recover gracefully from Conduit failure when building "Tags" field in commit mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 22 2015, 8:03 PM
This revision was automatically updated to reflect the committed changes.