Page MenuHomePhabricator

Improve arc's handling of dirty submodules in Git
ClosedPublic

Authored by epriestley on Sep 21 2015, 6:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:02 AM
Unknown Object (File)
Wed, Apr 24, 3:08 PM
Unknown Object (File)
Wed, Apr 17, 2:42 PM
Unknown Object (File)
Tue, Apr 2, 11:57 AM
Unknown Object (File)
Mar 28 2024, 6:28 PM
Unknown Object (File)
Mar 15 2024, 4:10 PM
Unknown Object (File)
Mar 10 2024, 3:35 PM
Unknown Object (File)
Mar 10 2024, 2:41 PM
Subscribers
None

Details

Summary

Fixes T9455. Depends on D14136. When you have a dirty submodule:

$ nano submodule/file.c # save changes

...we currently ask you to make a commit when you run arc diff, which is meaningless and misleading.

Instead, prompt the user separately.

This behavior isn't perfect but I think it's about the best we can do within reason.

Test Plan
  • Ran arc diff in a working copy with uncommitted submodule changes only, got new prompt.
  • Ran arc diff in a working copy with submodule base commit changes only, got old (correct) prompt.
  • Ran arc diff in a working copy with both, got only old prompt (which is incomplete, but reasonable/meaningful).

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve arc's handling of dirty submodules in Git.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 21 2015, 6:53 PM
epriestley edited edge metadata.
  • Use tsprintf() for all ConsoleTables.
This revision was automatically updated to reflect the committed changes.