Page MenuHomePhabricator
Differential D14134

Don't allow welcome mail to be sent to users who can't login
ClosedPublic
Actions

Authored by epriestley on Sep 19 2015, 11:48 PM.
Tags
None
Referenced Files
F14057520: D14134.id34139.diff
Sun, Nov 17, 4:12 AM
F14045227: D14134.id.diff
Wed, Nov 13, 2:19 AM
F14013037: D14134.diff
Fri, Nov 1, 11:36 PM
F13977329: D14134.id34146.diff
Oct 18 2024, 6:06 PM
Unknown Object (File)
Oct 9 2024, 4:54 AM
Unknown Object (File)
Sep 12 2024, 8:06 AM
Unknown Object (File)
Sep 5 2024, 4:22 PM
Unknown Object (File)
Sep 4 2024, 10:04 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9446: "Send Welcome Email" action works for bots and mailing lists
Commits
Restricted Diffusion Commit
rPa0ed843d472a: Don't allow welcome mail to be sent to users who can't login
Summary

Fixes T9446. We allow administrators to send "Welcome" mail to bots and mailing lists.

This is harmless (these links do not function), but confusing.

Instead, disable this option in the UI and explain why it is disabled when it is clicked. Also prevent generation of this mail lower in the stack.

Test Plan
  • Viewed a bot page, saw action disabled, clicked it, got explanation.
  • Viewed a normal user page, saw action enabled, clicked it, sent welcome email.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34139.Sep 19 2015, 11:48 PM
epriestley retitled this revision from to Don't allow welcome mail to be sent to users who can't login.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9446: "Send Welcome Email" action works for bots and mailing lists.
chad accepted this revision.Sep 20 2015, 1:42 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 20 2015, 1:42 AM
Closed by commit rPa0ed843d472a: Don't allow welcome mail to be sent to users who can't login (authored by epriestley, committed by epriestley). · Explain WhySep 20 2015, 11:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
3 lines
25 lines
storage/
7 lines

Diff 34146

View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleWelcomeController.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Phabricator · Built by Phacility