Differential D14129

Add pageObjects to Macro
ClosedPublic
Actions

Authored by chad on Sep 18 2015, 8:57 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9442: Image macros do not include "objectPHID" on page details, so notifications don't clear

Commits

Restricted Diffusion Commit
rP36c8df3ef95b: Add pageObjects to Macro

Summary

Fixes T9442

Test Plan

Like a macro, log out, switch to notchad, clear notification by visiting page

Diff Detail

Repository

rP Phabricator

Branch

macro

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8006
Build 9042: [Placeholder Plan] Wait for 30 Seconds
Build 9041: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34130.Sep 18 2015, 8:57 PM

chad retitled this revision from to Add pageObjects to Macro.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9442: Image macros do not include "objectPHID" on page details, so notifications don't clear.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 18 2015, 8:57 PM

magnifique

src/applications/macro/controller/PhabricatorMacroViewController.php
95	(Is there one extra space here?)

This revision is now accepted and ready to land.Sep 18 2015, 8:57 PM

Closed by commit rP36c8df3ef95b: Add pageObjects to Macro (authored by chad, committed by chad). · Explain WhySep 18 2015, 8:58 PM

This revision was automatically updated to reflect the committed changes.

ugh

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroViewController.php

1 line

Diff 34130

View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Add pageObjects to MacroClosedPublicActions