Paths

Table of Contentst

Differential D14126

Allow AlmanacHost blueprints to build a meaningful CommandInterface
ClosedPublic
Actions

Authored by epriestley on Sep 17 2015, 2:51 PM.

Tags

None

Referenced Files

	F13808361: D14126.diff
	Mon, Sep 16, 11:12 PM

	Unknown Object (File)
	Thu, Sep 12, 8:06 AM

	Unknown Object (File)
	Thu, Sep 5, 4:20 PM

	Unknown Object (File)
	Wed, Sep 4, 1:12 AM

	Unknown Object (File)
	Tue, Sep 3, 10:47 PM

	Unknown Object (File)
	Sun, Sep 1, 12:03 AM

	Unknown Object (File)
	Sat, Aug 31, 2:32 PM

	Unknown Object (File)
	Sat, Aug 31, 2:32 PM

Subscribers

None

Details

Reviewers

hach-que
chad

Maniphest Tasks

T9253: Implement a Drydock blueprint for leasing hosts from a static, pre-built Almanac pool

Commits

Restricted Diffusion Commit
rP6a0eb9d84b5a: Allow AlmanacHost blueprints to build a meaningful CommandInterface

Summary

Ref T9253. Provide a meaningful command interface for Almanac hosts.

Test Plan

Configued and leased a real host (sbuild001.phacility.net) and ran a command on it.

$ ./bin/drydock command --lease 90 -- ls /
bin
boot
core
dev
etc
home
initrd.img
lib
lib64
lost+found
media
mnt
opt
proc
root
run
sbin
srv
sys
tmp
usr
var
vmlinuz

Diff Detail

Repository

Branch

drydock9

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php:139	XHP16	TODO Comment
Advice	src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php:129	XHP16	TODO Comment
Advice	src/applications/drydock/management/DrydockManagementCommandWorkflow.php:52	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 8000
Build 9030: [Placeholder Plan] Wait for 30 Seconds
Build 9029: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34120.Sep 17 2015, 2:51 PM

epriestley retitled this revision from to Allow AlmanacHost blueprints to build a meaningful CommandInterface.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, hach-que.

epriestley added a task: T9253: Implement a Drydock blueprint for leasing hosts from a static, pre-built Almanac pool.

chad accepted this revision.Sep 17 2015, 3:48 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 17 2015, 3:48 PM

hach-que accepted this revision.Sep 17 2015, 7:20 PM

hach-que edited edge metadata.

Closed by commit rP6a0eb9d84b5a: Allow AlmanacHost blueprints to build a meaningful CommandInterface (authored by epriestley, committed by epriestley). · Explain WhySep 21 2015, 11:46 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D10469: [drydock/core] Implement `drydock run-command` for running commands against leases.Sep 23 2015, 5:49 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

drydock/

blueprint/

DrydockAlmanacServiceHostBlueprintImplementation.php

30 lines

DrydockBlueprintImplementation.php

59 lines

DrydockWorkingCopyBlueprintImplementation.php

11 lines

interface/

DrydockInterface.php

6 lines

command/

DrydockCommandInterface.php

6 lines

DrydockLocalCommandInterface.php

DrydockSSHCommandInterface.php

68 lines

management/

DrydockManagementCommandWorkflow.php

66 lines

storage/

DrydockBlueprint.php

18 lines

Diff 34120

src/__phutil_library_map__.php

Loading...

src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php

Loading...

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

Loading...

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

Loading...

src/applications/drydock/interface/DrydockInterface.php

Loading...

src/applications/drydock/interface/command/DrydockCommandInterface.php

Loading...

src/applications/drydock/interface/command/DrydockLocalCommandInterface.php

Loading...

src/applications/drydock/interface/command/DrydockSSHCommandInterface.php

Loading...

src/applications/drydock/management/DrydockManagementCommandWorkflow.php

Loading...

src/applications/drydock/storage/DrydockBlueprint.php

Loading...