Page MenuHomePhabricator

Add Contact Information to Phortune Merchants
ClosedPublic

Authored by chad on Sep 17 2015, 4:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 1:40 PM
Unknown Object (File)
Tue, Dec 24, 4:49 AM
Unknown Object (File)
Fri, Dec 13, 12:46 AM
Unknown Object (File)
Thu, Dec 12, 6:48 AM
Unknown Object (File)
Dec 7 2024, 9:23 PM
Unknown Object (File)
Dec 6 2024, 11:10 AM
Unknown Object (File)
Dec 3 2024, 8:49 PM
Unknown Object (File)
Nov 30 2024, 6:37 AM
Subscribers

Details

Summary

Part of making this look/feel/be more professional is having decent receipts for billing, including contact information (whatever we want to put in there). I'm not using this anywhere at the moment, but will.

Test Plan

Add Contact Info, see Contact Info. Also, why is Remarkup not rendering with line breaks? Seems to be a OneOff thing... anywho... bears!

Diff Detail

Repository
rP Phabricator
Branch
phortune-merchant-address
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7999
Build 9028: [Placeholder Plan] Wait for 30 Seconds
Build 9027: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add Contact Information to Phortune Merchants.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.

I'm not sure this should be a primary field, since it's pretty much only useful in email and I think all the Phacility email is going to go fully-custom as soon as I have a chance to touch it. If the email is fully custom anyway, we might as well just hard-coded it there so we have more flexibility (e.g., with style/layout in HTML mail).

I think we're completely forced to do fully custom mail in order to do other stuff like "Your trial period is about to end" with reasonable, tailored instructions about options.

My plan was to build an actual PhortuneCartPrintView page and have it be a real looking receipt. I hadn't really thought about email.

chad planned changes to this revision.

Will see where this is.

Transactions became fancy/modular enough that I was able to eventually fake our way through most of the email content customization, so something in this vein should be good to go now.

chad edited edge metadata.
  • clean up UI
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2016, 12:06 AM

Oh, but rename 20150917.phortune.contact.1.sql to something modern (2016...).

chad edited edge metadata.
  • move file
This revision was automatically updated to reflect the committed changes.