Add Contact Information to Phortune Merchants
ClosedPublic
Actions

Authored by chad on Sep 17 2015, 4:55 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T7607: Invoicing emails probably need some work

Commits

rPa69ac888b373: Add Contact Information to Phortune Merchants

Summary

Part of making this look/feel/be more professional is having decent receipts for billing, including contact information (whatever we want to put in there). I'm not using this anywhere at the moment, but will.

Test Plan

Add Contact Info, see Contact Info. Also, why is Remarkup not rendering with line breaks? Seems to be a OneOff thing... anywho... bears!

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34119.Sep 17 2015, 4:55 AM

chad retitled this revision from to Add Contact Information to Phortune Merchants.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 17 2015, 4:55 AM

I'm not sure this should be a primary field, since it's pretty much only useful in email and I think all the Phacility email is going to go fully-custom as soon as I have a chance to touch it. If the email is fully custom anyway, we might as well just hard-coded it there so we have more flexibility (e.g., with style/layout in HTML mail).

I think we're completely forced to do fully custom mail in order to do other stuff like "Your trial period is about to end" with reasonable, tailored instructions about options.

My plan was to build an actual PhortuneCartPrintView page and have it be a real looking receipt. I hadn't really thought about email.

chad abandoned this revision.Oct 28 2015, 6:28 PM

Will see where this is.

Transactions became fancy/modular enough that I was able to eventually fake our way through most of the email content customization, so something in this vein should be good to go now.