Page MenuHomePhabricator
Differential D14123

Normalize Paste, Remarkup code embed colors
ClosedPublic
Actions

Authored by chad on Sep 17 2015, 3:54 AM.
Tags
None
Referenced Files
F15516945: D14123.diff
Fri, Apr 18, 10:33 PM
F15506488: D14123.diff
Tue, Apr 15, 11:40 AM
F15477682: D14123.id.diff
Mon, Apr 7, 5:19 PM
F15476648: D14123.id.diff
Mon, Apr 7, 8:11 AM
F15474635: D14123.diff
Sun, Apr 6, 10:39 AM
F15390108: D14123.id34123.diff
Mar 15 2025, 5:54 AM
Unknown Object (File)
Feb 11 2025, 1:26 PM
Unknown Object (File)
Feb 11 2025, 1:26 PM
View All Files
Subscribers
Korvin
tycho.tatitscheff

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPce7aa92c6778: Normalize Paste, Remarkup code embed colors
Summary

These currently use different yellows, and more importantly when pygmentized, is hard to read. This lightens up code embeds and pastes.

Test Plan

Review Diviner docs, Pastes, and normal code embeds.

pasted_file (111×774 px, 41 KB)

Diff Detail

Repository
rP Phabricator
Branch
code-embed-remarkup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7997
Build 9024: [Placeholder Plan] Wait for 30 Seconds
Build 9023: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34117.Sep 17 2015, 3:54 AM
chad retitled this revision from to Normalize Paste, Remarkup code embed colors.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 17 2015, 3:54 AM
chad edited the test plan for this revision. (Show Details)Sep 17 2015, 3:54 AM
epriestley accepted this revision.Sep 17 2015, 2:54 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 17 2015, 2:54 PM
tycho.tatitscheff added a subscriber: tycho.tatitscheff.Sep 17 2015, 3:22 PM

Does this also standardize the yellow used for inline selection in Diffusion ?

Closed by commit rPce7aa92c6778: Normalize Paste, Remarkup code embed colors (authored by chad, committed by chad). · Explain WhySep 17 2015, 3:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
webroot/
rsrc/
css/
core/
6 lines
layout/
4 lines

Diff 34117

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...
Phabricator · Built by Phacility