Page MenuHomePhabricator

Modernize Drydock Query + Attach code
ClosedPublic

Authored by epriestley on Sep 15 2015, 5:01 PM.
Tags
None
Referenced Files
F17807524: D14113.diff
Fri, Jul 25, 3:00 PM
F17763543: D14113.diff
Tue, Jul 22, 11:32 PM
Unknown Object (File)
Jun 1 2025, 11:50 PM
Unknown Object (File)
May 29 2025, 9:50 AM
Unknown Object (File)
May 28 2025, 5:08 PM
Unknown Object (File)
May 9 2025, 4:49 PM
Unknown Object (File)
May 6 2025, 8:25 AM
Unknown Object (File)
May 1 2025, 10:55 AM
Subscribers
None

Details

Summary

Ref T9253. Some of the Drydock code is pretty old. This applies standard modernizations to it:

  • Modernize Query classes to use stuff like buildWhereClauseParts() and loadStandardPage().
  • Modernize all the getX() / attachX() stuff. In particular:
    • Require and attach implementations to Blueprints.
    • Require and attach Blueprints to Resources.
    • BlueprintImplementations are now always unique per-Blueprint so they can store/cache state if they want without running over one another.
    • BlueprintImplementations are now passed a $blueprint, like other similar APIs (this could go various ways but I generally like this as a balance of concerns).
NOTE: This probably doesn't run on its own, I'm just trying to split the next diff (core allocator stuff) up a bit and these pieces are all pretty standard.
Test Plan
  • Not much; see next revision or two.
  • Clicked around Resource and Blueprint lists.

Diff Detail

Repository
rP Phabricator
Branch
drydock4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7987
Build 9004: [Placeholder Plan] Wait for 30 Seconds
Build 9003: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modernize Drydock Query + Attach code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 15 2015, 6:04 PM
hach-que edited edge metadata.
This revision was automatically updated to reflect the committed changes.