Page MenuHomePhabricator

Modernize Drydock Query + Attach code
ClosedPublic

Authored by epriestley on Sep 15 2015, 5:01 PM.
Tags
None
Referenced Files
F15458224: D14113.id34104.diff
Sun, Mar 30, 9:52 PM
F15455665: D14113.diff
Sun, Mar 30, 4:07 AM
F15452792: D14113.id34104.diff
Sat, Mar 29, 7:17 AM
F15449636: D14113.id.diff
Fri, Mar 28, 11:22 AM
F15446852: D14113.diff
Thu, Mar 27, 8:30 PM
F15446378: D14113.diff
Thu, Mar 27, 6:46 PM
F15421912: D14113.id.diff
Sat, Mar 22, 3:26 AM
F15419417: D14113.diff
Fri, Mar 21, 5:59 AM
Subscribers
None

Details

Summary

Ref T9253. Some of the Drydock code is pretty old. This applies standard modernizations to it:

  • Modernize Query classes to use stuff like buildWhereClauseParts() and loadStandardPage().
  • Modernize all the getX() / attachX() stuff. In particular:
    • Require and attach implementations to Blueprints.
    • Require and attach Blueprints to Resources.
    • BlueprintImplementations are now always unique per-Blueprint so they can store/cache state if they want without running over one another.
    • BlueprintImplementations are now passed a $blueprint, like other similar APIs (this could go various ways but I generally like this as a balance of concerns).
NOTE: This probably doesn't run on its own, I'm just trying to split the next diff (core allocator stuff) up a bit and these pieces are all pretty standard.
Test Plan
  • Not much; see next revision or two.
  • Clicked around Resource and Blueprint lists.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modernize Drydock Query + Attach code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 15 2015, 6:04 PM
hach-que edited edge metadata.
This revision was automatically updated to reflect the committed changes.