Paths

Table of Contentst

Differential D14083

Fix missing `willUpload` hook for drag-and-drop chunked upload
ClosedPublic
Actions

Authored by epriestley on Sep 8 2015, 4:37 PM.

Details

Reviewers

chad

Maniphest Tasks

T9324: Create an "Upload Files" interaction for Phacility instances

Commits

Restricted Diffusion Commit
rPd2374c468fdc: Fix missing `willUpload` hook for drag-and-drop chunked upload

Summary

Ref T9324. When you upload a normal file, we call willUpload and then didUpload.

When you upload a chunked file, we never call willUpload. This can get things out of sync. Make sure we invoke this event for both chunked and non-chunked uploads.

Test Plan

Got cleaner behavior (redirect after all uploads finish) in new Phacility file upload area.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34032.Sep 8 2015, 4:37 PM

epriestley retitled this revision from to Fix missing `willUpload` hook for drag-and-drop chunked upload.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9324: Create an "Upload Files" interaction for Phacility instances.

chad accepted this revision.Sep 8 2015, 5:26 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 8 2015, 5:26 PM

Closed by commit rPd2374c468fdc: Fix missing `willUpload` hook for drag-and-drop chunked upload (authored by epriestley, committed by epriestley). · Explain WhySep 8 2015, 11:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

webroot/

rsrc/

js/

core/

DragAndDropFileUpload.js

2 lines

Diff 34043

View Options

resources/celerity/map.php