Page MenuHomePhabricator

Correct a bad Herald migration
ClosedPublic

Authored by epriestley on Sep 4 2015, 9:58 PM.
Tags
None
Referenced Files
F18815783: D14061.id33997.diff
Tue, Oct 21, 3:40 AM
F18774700: D14061.id33997.diff
Fri, Oct 10, 4:39 PM
F18759771: D14061.id33996.diff
Mon, Oct 6, 5:50 AM
F18717288: D14061.id.diff
Mon, Sep 29, 1:25 PM
F18702911: D14061.diff
Sun, Sep 28, 2:06 AM
F18670276: D14061.id33997.diff
Wed, Sep 24, 11:38 PM
F18647759: D14061.diff
Sep 19 2025, 2:52 PM
F18598095: D14061.diff
Sep 13 2025, 4:20 AM
Subscribers
None
Tokens
"Yellow Medal" token, awarded by meitros.

Details

Summary

One of the migrations in rPa335004a91 (20150730.herald.5.sql) incorrectly swapped "add" and "add blocking" Differential Herald rules.

Swap any rules last modified before this patch was applied back. This is the best we can do without possibly overwriting more recent, intentional data. I'll issue some guidance on this in the changelog.

Test Plan
  • Made a rule, ran patch, no change.
  • Changed rule modified time to a few months ago, ran patch, saw swap from non-blocking to blocking.

Diff Detail

Repository
rP Phabricator
Branch
heraldswap
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7916
Build 8861: [Placeholder Plan] Wait for 30 Seconds
Build 8860: arc lint + arc unit