Page MenuHomePhabricator

Fix callsites which called libphutil_console_wrap like it were _format

Authored by alexmv on Sep 3 2015, 6:43 PM.



7e2df9a attempted to pht() some strings; unfortunately, it assumed
that some things that were calls to phutil_console_wrap() were
actually calls to phutil_console_format(). This produces errors of
the form:

[2015-07-17 21:17:28] ERROR 2: str_repeat() expects parameter 2 to be long, string given at [/usr/local/libphutil/src/console/format.php:162]
#0 str_repeat(string, string) called at [<phutil>/src/console/format.php:162]
#1 phutil_console_wrap(string, string, string) called at [<arcanist>/scripts/arcanist.php:620]
#2 arcanist_load_libraries(array, boolean, string, ArcanistWorkingCopyIdentity) called at [<arcanist>/scripts/arcanist.php:154]
%s: %s

Provide an additional call to phutil_console_format() when necessary,
or simply append the relevant characters if possible.

Test Plan

Caused a library load error

Diff Detail

rARC Arcanist
Lint Not Applicable
Tests Not Applicable

Event Timeline

alexmv retitled this revision from to Fix callsites which called libphutil_console_wrap like it were _format.
alexmv updated this object.
alexmv edited the test plan for this revision. (Show Details)
alexmv added a reviewer: epriestley.

I believe Dropbox has now signed the Corporate CLA, which should suffice to cover this submission.

This revision is now accepted and ready to land.Sep 3 2015, 7:01 PM
This revision was automatically updated to reflect the committed changes.