Page MenuHomePhabricator
Differential D13994

Minor tidying of parser_nodes script
ClosedPublic
Actions

Authored by joshuaspence on Aug 26 2015, 8:02 AM.
Tags
None
Referenced Files
F15530348: D13994.diff
Wed, Apr 23, 3:22 AM
F15520840: D13994.id33839.diff
Sun, Apr 20, 8:42 AM
F15520839: D13994.id33818.diff
Sun, Apr 20, 8:42 AM
F15519935: D13994.diff
Sun, Apr 20, 1:17 AM
F15519765: D13994.diff
Sat, Apr 19, 11:44 PM
F15518737: D13994.id.diff
Sat, Apr 19, 4:26 PM
F15516588: D13994.diff
Fri, Apr 18, 7:53 PM
F15514473: D13994.id.diff
Fri, Apr 18, 2:54 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUa00d404cb723: Minor tidying of parser_nodes script
Summary

Various minor improvements to parser_nodes.php, including:

  • Use libphutil functions instead of vanilla PHP.
  • phtize strings.
  • Use an array instead of a heredoc for representing the nodes.
Test Plan

Ran the script and compared ouptut.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33818.Aug 26 2015, 8:02 AM
joshuaspence retitled this revision from to Minor tidying of parser_nodes script.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 26 2015, 8:02 AM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley requested changes to this revision.Aug 27 2015, 11:22 AM
epriestley added a reviewer: epriestley.

Seems basically fine but WIP.

This revision now requires changes to proceed.Aug 27 2015, 11:22 AM
joshuaspence updated this object.Aug 27 2015, 12:11 PM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
joshuaspence added inline comments.
support/xhpast/generate_nodes.php
1

This is wrong.

joshuaspence requested a review of this revision.Aug 27 2015, 12:53 PM
joshuaspence edited edge metadata.

It's good to go.

epriestley accepted this revision.Aug 27 2015, 2:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 27 2015, 2:50 PM
Closed by commit rPHUa00d404cb723: Minor tidying of parser_nodes script (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 27 2015, 9:03 PM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSize
support/
xhpast/
285 lines
6 lines

Diff 33839

View Options

support/xhpast/generate_nodes.php

Loading...
View Options

support/xhpast/parser_nodes.php

Loading...
Phabricator · Built by Phacility