Page MenuHomePhabricator

[drydock/core] Allow execution timeout to be set when running commands
AbandonedPublic

Authored by hach-que on Aug 24 2015, 7:51 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Summary

Ref T2015. This allows a maximum execution timeout to be set when running commands through Drydock. This change is pulled out of D10479, and this functionality is used when blueprints want to query the readiness of a host resource they've created, but don't want to stall forever if the remote host is not responsive.

Test Plan

Pulled out of D10479, which has been in production for 6+ months.

Diff Detail

Repository
rP Phabricator
Branch
drydock-ssh-timeout
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7755
Build 8542: [Placeholder Plan] Wait for 30 Seconds
Build 8541: arc lint + arc unit

Event Timeline

hach-que retitled this revision from to [drydock/core] Allow execution timeout to be set when running commands.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.

This abbreviation seems unnecessary -- is "ExecTimeout" referencing anything specific? If not, let's call this "ExecutionTimeout"?

src/applications/drydock/interface/command/DrydockSSHCommandInterface.php
52–67

Much of this can now be rewritten to use %Ls more clearly and safely, see DiffusionSSHWorkflow for an example construction which does not require %C.

This revision now requires changes to proceed.Aug 24 2015, 6:17 PM