Page MenuHomePhabricator

Tune document details in Legalpad
ClosedPublic

Authored by epriestley on Aug 23 2015, 2:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 4:43 PM
Unknown Object (File)
Sat, Nov 16, 9:55 PM
Unknown Object (File)
Fri, Nov 15, 10:41 PM
Unknown Object (File)
Thu, Nov 14, 9:57 AM
Unknown Object (File)
Sun, Nov 10, 7:43 AM
Unknown Object (File)
Sat, Nov 9, 10:00 AM
Unknown Object (File)
Sat, Nov 9, 10:00 AM
Unknown Object (File)
Sat, Nov 9, 9:59 AM
Subscribers
None

Details

Summary

Fixes T9245. These picked up some possibly-confusing metadata, like in the screenshot on T9245 where "Subscribers" appears in the middle of the page for no obvious reason.

  • Make these pages a little cleaner by removing elements which aren't important for signing agreements.
  • Use the last time the actual document text was updated as the modification time, not the last time the "Document" object was modified. The latter will change for trivial things like altering the view/edit policy, but that could be confusing if you see that a TOS was "last updated yesterday" but can't figure out what actually changed (since nothing changed).
Test Plan

Viewed signature page for a document.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33724.
epriestley retitled this revision from to Tune document details in Legalpad.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Fix comment wording.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 23 2015, 3:01 PM
This revision was automatically updated to reflect the committed changes.