diff --git a/src/applications/legalpad/controller/LegalpadDocumentSignController.php b/src/applications/legalpad/controller/LegalpadDocumentSignController.php --- a/src/applications/legalpad/controller/LegalpadDocumentSignController.php +++ b/src/applications/legalpad/controller/LegalpadDocumentSignController.php @@ -234,11 +234,19 @@ $document, PhabricatorPolicyCapability::CAN_EDIT); + // Use the last content update as the modified date. We don't want to + // show that a document like a TOS was "updated" by an incidental change + // to a field like the preamble or privacy settings which does not acutally + // affect the content of the agreement. + $content_updated = $document_body->getDateCreated(); + + // NOTE: We're avoiding `setPolicyObject()` here so we don't pick up + // extra UI elements that are unnecessary and clutter the signature page. + // These details are available on the "Manage" page. $header = id(new PHUIHeaderView()) ->setHeader($title) ->setUser($viewer) - ->setPolicyObject($document) - ->setEpoch($document->getDateModified()) + ->setEpoch($content_updated) ->addActionLink( id(new PHUIButtonView()) ->setTag('a') @@ -258,15 +266,16 @@ 'default', $viewer); + // NOTE: We're avoiding `setObject()` here so we don't pick up extra UI + // elements like "Subscribers". This information is available on the + // "Manage" page, but just clutters up the "Signature" page. $preamble = id(new PHUIPropertyListView()) ->setUser($viewer) - ->setObject($document) ->addSectionHeader(pht('Preamble')) ->addTextContent($preamble_text); $preamble_box = new PHUIPropertyGroupView(); $preamble_box->addPropertyList($preamble); - } $content = id(new PHUIDocumentView())