Paths

Table of Contentst

Use semantic versioning for XHPAST
ClosedPublic
Actions

Authored by joshuaspence on Aug 22 2015, 1:25 AM.

Tags

None

Referenced Files

	F14048304: D13960.id33693.diff
	Thu, Nov 14, 7:25 AM

	F14025696: D13960.id33693.diff
	Thu, Nov 7, 7:48 PM

	F14025115: D13960.id33693.diff
	Thu, Nov 7, 2:33 PM

	F14022633: D13960.id33697.diff
	Wed, Nov 6, 6:27 PM

	F14022632: D13960.id33693.diff
	Wed, Nov 6, 6:27 PM

	F14022631: D13960.id.diff
	Wed, Nov 6, 6:27 PM

	F14022630: D13960.diff
	Wed, Nov 6, 6:26 PM

	F14017679: D13960.diff
	Mon, Nov 4, 9:16 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUe276f31b7117: Use semantic versioning for XHPAST

Summary

Currently XHPAST is versioned as x.y.z/w which seems a little odd. Instead, use x.y.z as the version number to make it possible to use version_compare.

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33693.Aug 22 2015, 1:25 AM

joshuaspence retitled this revision from to Use semantic versioning for XHPAST.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 22 2015, 1:25 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 22 2015, 10:54 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 22 2015, 10:54 AM

Closed by commit rPHUe276f31b7117: Use semantic versioning for XHPAST (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 22 2015, 11:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

bin/

PhutilXHPASTBinary.php

2 lines

support/

xhpast/

xhpast.cpp

2 lines

Diff 33697

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php