There is still some general buginess with answer comments, trying to work them out. This replaces timeline rendering into one offs (less performant) but resolves many bugs. Or if there is a more performant way, let me know? Also when leaving an answer comment, you currently get redirected back to the page, but both the comment form is still populated and you dont see your answer without a reload. I feel like I'm missing some magical parameter to pass, so just redirecting back to the question itself.
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rP5317f77f30eb: Fix some quirkiness with Answer comments in Ponder
Leave lots of answer comments.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- ponder-answer-timeline
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7697 Build 8431: [Placeholder Plan] Wait for 30 Seconds Build 8430: arc lint + arc unit
Event Timeline
Comment Actions
I think this is fine, the performance cost shouldn't be substantial.
Not sure about the reload thing, I can take a look at some point.