Page MenuHomePhabricator

Fix some quirkiness with Answer comments in Ponder
ClosedPublic

Authored by chad on Aug 20 2015, 5:32 PM.
Tags
None
Referenced Files
F13059756: D13946.diff
Fri, Apr 19, 4:46 PM
Unknown Object (File)
Mon, Apr 15, 4:24 PM
Unknown Object (File)
Fri, Apr 12, 7:18 PM
Unknown Object (File)
Fri, Apr 12, 7:18 PM
Unknown Object (File)
Fri, Apr 12, 7:05 PM
Unknown Object (File)
Fri, Apr 12, 6:38 PM
Unknown Object (File)
Thu, Apr 11, 5:40 PM
Unknown Object (File)
Thu, Apr 11, 5:30 PM
Subscribers

Details

Summary

There is still some general buginess with answer comments, trying to work them out. This replaces timeline rendering into one offs (less performant) but resolves many bugs. Or if there is a more performant way, let me know? Also when leaving an answer comment, you currently get redirected back to the page, but both the comment form is still populated and you dont see your answer without a reload. I feel like I'm missing some magical parameter to pass, so just redirecting back to the question itself.

Test Plan

Leave lots of answer comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Fix some quirkiness with Answer comments in Ponder.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

I think this is fine, the performance cost shouldn't be substantial.

Not sure about the reload thing, I can take a look at some point.

This revision is now accepted and ready to land.Aug 20 2015, 6:13 PM
This revision was automatically updated to reflect the committed changes.