Page MenuHomePhabricator

ArcanistPyLintLinter fix to getMandatoryFlags msg-template
ClosedPublic

Authored by e-m-albright on Aug 18 2015, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 7:48 PM
Unknown Object (File)
Tue, Mar 5, 3:40 PM
Unknown Object (File)
Sun, Mar 3, 7:36 PM
Unknown Object (File)
Sun, Mar 3, 7:36 PM
Unknown Object (File)
Feb 9 2024, 7:30 AM
Unknown Object (File)
Feb 1 2024, 11:28 AM
Unknown Object (File)
Dec 27 2023, 6:43 AM
Unknown Object (File)
Dec 21 2023, 1:54 PM

Details

Summary

Removed excess quotations on the --msg-template option as it was interfering with the string-int coercion

Test Plan

Unsure

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

e-m-albright retitled this revision from to ArcanistPyLintLinter fix to getMandatoryFlags msg-template.
e-m-albright updated this object.
e-m-albright edited the test plan for this revision. (Show Details)
e-m-albright added a reviewer: epriestley.

Apologies for the lack of unit testing and linting. I wouldn't think to submit this without them if they were anything more complicated than losing two quotation marks.

If I'm making any mistakes in the process here, I'm happy to learn/correct them!

Thanks again.

joshuaspence added a reviewer: joshuaspence.

I ran the unit tests locally and they still pass.

This revision is now accepted and ready to land.Aug 19 2015, 12:17 PM
epriestley edited edge metadata.
This revision was automatically updated to reflect the committed changes.