Page MenuHomePhabricator
Differential D13931

ArcanistPyLintLinter fix to getMandatoryFlags msg-template
ClosedPublic
Actions

Authored by • e-m-albright on Aug 18 2015, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 2, 11:44 PM
Unknown Object (File)
Fri, May 2, 4:28 AM
Unknown Object (File)
Wed, Apr 30, 11:12 AM
Unknown Object (File)
Wed, Apr 30, 11:12 AM
Unknown Object (File)
Mon, Apr 21, 8:04 PM
Unknown Object (File)
Sat, Apr 19, 12:45 PM
Unknown Object (File)
Sat, Apr 19, 1:49 AM
Unknown Object (File)
Fri, Apr 18, 1:44 PM
View All Files
Subscribers
• e-m-albright
joshuaspence
Korvin

Details

Reviewers
joshuaspence
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9214: ArcanistPyLintLinter.php has superfluous quotations around the "msg-template" options.
Commits
rARC05aaa1a5a3b8: ArcanistPyLintLinter fix to getMandatoryFlags msg-template
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Removed excess quotations on the --msg-template option as it was interfering with the string-int coercion

Test Plan

Unsure

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• e-m-albright updated this revision to Diff 33627.Aug 18 2015, 8:50 PM
• e-m-albright retitled this revision from to ArcanistPyLintLinter fix to getMandatoryFlags msg-template.
• e-m-albright updated this object.
• e-m-albright edited the test plan for this revision. (Show Details)
• e-m-albright added a reviewer: epriestley.
• e-m-albright added subscribers: • e-m-albright, joshuaspence.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 18 2015, 8:50 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: Korvin. · View Herald Transcript
• e-m-albright added a task: T9214: ArcanistPyLintLinter.php has superfluous quotations around the "msg-template" options..Aug 18 2015, 8:51 PM
• e-m-albright added a comment.Aug 18 2015, 8:55 PM

Apologies for the lack of unit testing and linting. I wouldn't think to submit this without them if they were anything more complicated than losing two quotation marks.

If I'm making any mistakes in the process here, I'm happy to learn/correct them!

Thanks again.

joshuaspence accepted this revision.Aug 19 2015, 12:17 PM
joshuaspence added a reviewer: joshuaspence.

I ran the unit tests locally and they still pass.

This revision is now accepted and ready to land.Aug 19 2015, 12:17 PM
epriestley edited edge metadata.Aug 19 2015, 12:45 PM

Thanks!

epriestley accepted this revision.Aug 19 2015, 12:45 PM
epriestley edited edge metadata.
Closed by commit rARC05aaa1a5a3b8: ArcanistPyLintLinter fix to getMandatoryFlags msg-template (authored by ealbright <ealbright@terrapower.com>, committed by epriestley). · Explain WhyAug 19 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9214: ArcanistPyLintLinter.php has superfluous quotations around the "msg-template" options..Aug 19 2015, 1:53 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
2 lines

Diff 33646

View Options

src/lint/linter/ArcanistPyLintLinter.php

Loading...
Phabricator · Built by Phacility