Differential D13917

Add a linter rule for global constants
Needs RevisionPublic
Actions

Authored by joshuaspence on Aug 17 2015, 12:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 18, 3:14 PM

	Unknown Object (File)
	Aug 4 2024, 2:33 PM

	Unknown Object (File)
	May 18 2024, 10:57 AM

	Unknown Object (File)
	May 16 2024, 9:10 AM

	Unknown Object (File)
	Oct 7 2023, 2:53 AM

	Unknown Object (File)
	Aug 18 2023, 4:41 PM

	Unknown Object (File)
	May 21 2023, 3:01 AM

	Unknown Object (File)
	Mar 18 2023, 2:36 AM

View All 54 Files

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

WIP

Test Plan

WIP

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7654
Build 8346: [Placeholder Plan] Wait for 30 Seconds
Build 8345: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,622 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	496 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	8,045 ms	ArcanistXHPASTLinterTestCase::Unknown Unit Message ("")
	790 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	151 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (3 Failed · 36 Passed · 19 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 33584.Aug 17 2015, 12:24 AM

joshuaspence retitled this revision from to Add a linter rule for global constants.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 17 2015, 12:24 AM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley requested changes to this revision.Aug 17 2015, 12:43 AM

epriestley added a reviewer: epriestley.

epriestley added inline comments.

src/lint/linter/xhpast/rules/ArcanistGlobalConstantXHPASTLinterRule.php
23–24	I think this is a reference to a private task on your install?

This revision now requires changes to proceed.Aug 17 2015, 12:43 AM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

__phutil_library_map__.php

2 lines

-

-

lint/

linter/

__tests__/

xhpast/

global-constant.lint-test

7 lines

-

-

xhpast/

rules/

ArcanistGlobalConstantXHPASTLinterRule.php

34 lines

66%

Loading...

Diff 33584

src/__phutil_library_map__.php

Loading...

src/lint/linter/tests/xhpast/global-constant.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistGlobalConstantXHPASTLinterRule.php

Loading...