Page MenuHomePhabricator

Simplify some transaction translations
ClosedPublic

Authored by chad on Aug 15 2015, 9:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 9:13 PM
Unknown Object (File)
Fri, Mar 8, 12:46 PM
Unknown Object (File)
Wed, Mar 6, 4:43 AM
Unknown Object (File)
Tue, Mar 5, 7:03 PM
Unknown Object (File)
Tue, Mar 5, 7:03 PM
Unknown Object (File)
Feb 10 2024, 4:31 PM
Unknown Object (File)
Jan 20 2024, 4:48 PM
Unknown Object (File)
Jan 16 2024, 8:36 PM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
T8700: Add missing Translations
Commits
Restricted Diffusion Commit
rP5590642a1df0: Simplify some transaction translations
Summary

Ref T8700, I don't believe we need to be specific here about the object, since it displays on the object.

Test Plan

Change policy a few times on a task, see new translation

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Simplify some transaction translations.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

When I wrote these, my theory was that they were placeholders which would be separately specified in subclasses for each object type (since, as written, they aren't translatable), but it's very not practical to remember to do that. We could make them more clearly placeholdery. This seems fine too, though.

This revision is now accepted and ready to land.Aug 17 2015, 12:41 AM
This revision was automatically updated to reflect the committed changes.