Page MenuHomePhabricator

Get PhpunitTestEngine in working order
Needs ReviewPublic

Authored by rfreebern on Aug 14 2015, 12:40 AM.

Details

Summary

PhpunitTestEngine was missing some pieces in order to work. It didn't have a getEngineConfigurationName method or an instance of ArcanistConfigurationManager to work with.

Fixes T9174

Test Plan

Unit test included for getEngineConfigurationName method.

Tested locally against my own repo with the following:

.arcconfig
{
  "engines": {
    "phpunit": {
      "type": "phpunit",
      "include": "(\\.php$)",
      "exclude": "(^vendor/)"
    }
  }
}

Diff Detail

Repository
rARC Arcanist
Branch
phpunittestengine-configurationname
Lint
Lint SkippedExcuse: PHP Fatal error: Call to a member function getNonsemanticTokensBefore() on a non-object in /home/rfreebern/arcanist/src/lint/linter/xhpast/rules/ArcanistCallParenthesesXHPASTLinterRule.php on line 47
Unit
Unit Test Errors
Build Status
Buildable 7623
Build 8286: [Placeholder Plan] Wait for 30 Seconds
Build 8285: arc lint + arc unit

Event Timeline

rfreebern updated this revision to Diff 33537.Aug 14 2015, 12:40 AM
rfreebern retitled this revision from to Get PhpunitTestEngine in working order.
rfreebern updated this object.
rfreebern edited the test plan for this revision. (Show Details)
rfreebern added a reviewer: joshuaspence.