Page MenuHomePhabricator

Consolidate outbound mail status in a new class
ClosedPublic

Authored by epriestley on Aug 13 2015, 6:13 PM.
Tags
None
Referenced Files
F18774516: D13884.id.diff
Fri, Oct 10, 12:31 PM
F18756744: D13884.id33547.diff
Sun, Oct 5, 1:15 PM
F18683905: D13884.diff
Fri, Sep 26, 8:30 AM
F18498909: D13884.diff
Sep 4 2025, 7:09 PM
F18467545: D13884.diff
Sep 2 2025, 1:01 PM
F18108843: D13884.id33547.diff
Aug 11 2025, 9:48 AM
F18092790: D13884.id33546.diff
Aug 7 2025, 1:05 PM
F18089052: D13884.id33520.diff
Aug 6 2025, 10:17 AM
Subscribers
None

Details

Summary

Ref T5791. This collects outbound mail status in one place and makes the list view a little spiffier.

Test Plan

Looked at list and detail views. Grepped for changed classes/constants.

Diff Detail

Repository
rP Phabricator
Branch
hmail2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7629
Build 8297: [Placeholder Plan] Wait for 30 Seconds
Build 8296: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Consolidate outbound mail status in a new class.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 13 2015, 6:48 PM
src/applications/metamta/constants/PhabricatorMailOutboundStatus.php
27

fa-warning?

28

fa-send?

29

fa-trash?

I played with this a little bit today, and it was awesome. Not sure the tabs are needed, do you think more this page's information will continue to grow?

There's at least a bit more stuff coming, yeah (at a minimum: exposing mail tags more clearly, adding Herald routing information).

I also imagine this may start looking and working a little more like your Gmail inbox eventually, where some users might read some of their mail directly from the web UI, so I'm trying to bend it in that direction a bit. I think the primary use case for this UI will be "understand what happened to mail", at least for a while, but I'd like to see if "read mail" can also eventually be a major use case. Stuff like "mail headers" is a little bit helpful in understanding what happened to mail, but totally useless when reading mail, which is why I moved it to a separate tab and tried to make the main view look about as much like an inbox message as it can.

epriestley edited edge metadata.
  • Use different icons for different statuses.
This revision was automatically updated to reflect the committed changes.