Paths

Table of Contentst

Differential D13883

Add a Composer linter
ClosedPublic
Actions

Authored by joshuaspence on Aug 13 2015, 11:31 AM.

Tags

None

Referenced Files

	F18784593: D13883.id33519.diff
	Oct 13 2025, 1:21 PM

	F18712690: D13883.id.diff
	Sep 29 2025, 5:30 AM

	F18600405: D13883.diff
	Sep 13 2025, 9:41 AM

	F18367784: D13883.diff
	Aug 28 2025, 12:06 AM

	F18367773: D13883.diff
	Aug 28 2025, 12:05 AM

	F18085068: D13883.diff
	Aug 5 2025, 6:59 PM

	F18044744: D13883.diff
	Aug 3 2025, 7:42 AM

	Unknown Object (File)
	May 8 2025, 10:03 AM

Subscribers

Tokens

"Like" token, awarded by johnny-bit.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCf9bd6b058f8a: Add a Composer linter

Summary

Adds a basic linter for ensuring that composer.lock files are up-to-date.

Test Plan

We have been using this in a private project for around a month.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33519.Aug 13 2015, 11:31 AM

joshuaspence retitled this revision from to Add a Composer linter.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 13 2015, 11:31 AM

Herald added a subscriber: Korvin. · View Herald Transcript

johnny-bit awarded a token.Aug 13 2015, 12:35 PM

johnny-bit added a subscriber: johnny-bit.

epriestley accepted this revision.Aug 13 2015, 2:38 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 13 2015, 2:38 PM

I can write tests for this linter if you want, but it might require some modifications to ArcanistLinterTestCase because this linter effectively requires two files to exist with a specific filename.

joshuaspence added inline comments.Aug 13 2015, 9:22 PM

src/lint/linter/ArcanistComposerLinter.php
31	This seemed nicer than having to set a regex in `.arclint`.

Closed by commit rARCf9bd6b058f8a: Add a Composer linter (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 19 2015, 11:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

lint/

linter/

ArcanistComposerLinter.php

55 lines

Diff 33645

src/__phutil_library_map__.php

Loading...

src/lint/linter/ArcanistComposerLinter.php

Loading...