Page MenuHomePhabricator
Differential D13883

Add a Composer linter
ClosedPublic
Actions

Authored by joshuaspence on Aug 13 2015, 11:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 4:55 AM
Unknown Object (File)
Sun, Jan 19, 9:21 AM
Unknown Object (File)
Wed, Jan 8, 2:36 PM
Unknown Object (File)
Thu, Jan 2, 9:31 PM
Unknown Object (File)
Dec 21 2024, 1:39 PM
Unknown Object (File)
Dec 6 2024, 7:29 AM
Unknown Object (File)
Dec 1 2024, 7:41 AM
Unknown Object (File)
Nov 27 2024, 3:36 AM
View All Files
Subscribers
johnny-bit
Korvin
Tokens
"Like" token, awarded by johnny-bit.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCf9bd6b058f8a: Add a Composer linter
Summary

Adds a basic linter for ensuring that composer.lock files are up-to-date.

Test Plan

We have been using this in a private project for around a month.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33519.Aug 13 2015, 11:31 AM
joshuaspence retitled this revision from to Add a Composer linter.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 13 2015, 11:31 AM
Herald added a subscriber: Korvin. · View Herald Transcript
johnny-bit awarded a token.Aug 13 2015, 12:35 PM
johnny-bit added a subscriber: johnny-bit.
epriestley accepted this revision.Aug 13 2015, 2:38 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 13 2015, 2:38 PM
joshuaspence added a comment.Aug 13 2015, 9:21 PM

I can write tests for this linter if you want, but it might require some modifications to ArcanistLinterTestCase because this linter effectively requires two files to exist with a specific filename.

joshuaspence added inline comments.Aug 13 2015, 9:22 PM
src/lint/linter/ArcanistComposerLinter.php
31

This seemed nicer than having to set a regex in .arclint.

Closed by commit rARCf9bd6b058f8a: Add a Composer linter (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 19 2015, 11:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
lint/
linter/
55 lines

Diff 33645

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/ArcanistComposerLinter.php

Loading...
Phabricator · Built by Phacility