Page MenuHomePhabricator
Differential D13876

Micro-optimization for linting performance
ClosedPublic
Actions

Authored by joshuaspence on Aug 12 2015, 5:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 11:10 PM
Unknown Object (File)
Sat, Jan 11, 7:24 PM
Unknown Object (File)
Sun, Jan 5, 8:16 AM
Unknown Object (File)
Sat, Jan 4, 5:23 PM
Unknown Object (File)
Mon, Dec 23, 2:52 PM
Unknown Object (File)
Wed, Dec 18, 10:55 AM
Unknown Object (File)
Tue, Dec 17, 9:08 PM
Unknown Object (File)
Tue, Dec 17, 9:08 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUc76b692447af: Micro-optimization for linting performance
Summary

This is a micro-optimization to improve the performance of the XHPAST linter.

Test Plan

Ran arc lint --everything --never-apply-patches --xprofile=profile.json in rP. Compared the XHProf profile before and after.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33505.Aug 12 2015, 5:05 AM
joshuaspence retitled this revision from to Micro-optimization for linting.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 12 2015, 5:05 AM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence added a comment.Aug 12 2015, 9:15 AM

I'm not entirely convinced that this is a good idea, but thought I'd pose the question.

Personally, it feels like assert_instances_of is something that should almost be a no-op when not running in development mode.

joshuaspence retitled this revision from Micro-optimization for linting to Micro-optimization for linting performance.Aug 12 2015, 9:16 AM
joshuaspence edited edge metadata.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Aug 12 2015, 1:47 PM
epriestley edited edge metadata.

I think this is fine to remove any time it shows up on a profile. I've made similar changes once or twice elsewhere.

In the general case I still want it to run in production, because it makes debugging easier.

My only thought is that maybe we should leave a comment when we remove it so it doesn't get confused for an oversight later.

This revision is now accepted and ready to land.Aug 12 2015, 1:47 PM
Closed by commit rPHUc76b692447af: Micro-optimization for linting performance (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 12 2015, 9:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
aast/
api/
3 lines

Diff 33513

View Options

src/parser/aast/api/AASTNodeList.php

Loading...
Phabricator · Built by Phacility