Page MenuHomePhabricator
Differential D13857

Add a linter rule for the use of `parse_str`
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 2:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 3:15 PM
Unknown Object (File)
Fri, Dec 13, 8:19 AM
Unknown Object (File)
Wed, Dec 4, 1:05 PM
Unknown Object (File)
Wed, Nov 27, 7:46 AM
Unknown Object (File)
Nov 23 2024, 11:23 AM
Unknown Object (File)
Nov 19 2024, 11:46 AM
Unknown Object (File)
Nov 15 2024, 8:11 AM
Unknown Object (File)
Nov 11 2024, 3:34 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCfe8ed2a6f8b0: Add a linter rule for the use of `parse_str`
Summary

The use of the parse_str method (when called without sepcifying a second parameter) hinders static analysis. Specifically, the parse_str('...') behaves similarly to extract.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33470.Aug 11 2015, 2:00 AM
joshuaspence retitled this revision from to Add a linter rule for the use of `parse_str`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 2:00 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 11 2015, 2:56 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2015, 2:56 AM
Closed by commit rARCfe8ed2a6f8b0: Add a linter rule for the use of `parse_str` (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 13 2015, 9:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33530

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/extract-use.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/parse_str-use.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistParseStrUseXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistUndeclaredVariableXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility