Page MenuHomePhabricator

Link to Harbormaster build targets from the Daemon worker page
ClosedPublic

Authored by epriestley on Aug 10 2015, 6:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 11:44 PM
Unknown Object (File)
Sat, Nov 30, 7:43 AM
Unknown Object (File)
Mon, Nov 25, 7:52 AM
Unknown Object (File)
Mon, Nov 25, 6:44 AM
Unknown Object (File)
Wed, Nov 20, 6:20 PM
Unknown Object (File)
Nov 16 2024, 4:40 PM
Unknown Object (File)
Nov 11 2024, 5:57 AM
Unknown Object (File)
Nov 11 2024, 5:57 AM
Subscribers
None

Details

Summary

Fixes T7370. Two changes:

  • Make the default to show nothing, instead of showing all the data. This is a better default because the data is sometimes sensitive. Workers should have to opt in to revealing it.
  • For TargetWorkers, link to the target (technically the build, for now, since there's no dedicated target detail page).
Test Plan

Screen Shot 2015-08-10 at 11.47.16 AM.png (1×2 px, 376 KB)

Diff Detail

Repository
rP Phabricator
Branch
harbor2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7561
Build 8162: [Placeholder Plan] Wait for 30 Seconds
Build 8161: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Link to Harbormaster build targets from the Daemon worker page.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Do the same thing for BuildWorkers.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 7:25 PM
This revision was automatically updated to reflect the committed changes.