Page MenuHomePhabricator
Differential D13842

Add a linter rule for array elements
ClosedPublic
Actions

Authored by joshuaspence on Aug 10 2015, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 3:21 AM
Unknown Object (File)
Sun, Nov 17, 9:37 AM
Unknown Object (File)
Mon, Nov 11, 5:57 AM
Unknown Object (File)
Mon, Nov 11, 5:57 AM
Unknown Object (File)
Thu, Nov 7, 3:50 AM
Unknown Object (File)
Thu, Nov 7, 3:50 AM
Unknown Object (File)
Wed, Nov 6, 6:19 PM
Unknown Object (File)
Wed, Nov 6, 6:19 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC830bcbc2a5e9: Add a linter rule for array elements
Summary

Add a linter rule to ensure that array elements occupy a single line each.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33423.Aug 10 2015, 1:38 PM
joshuaspence retitled this revision from to Add a linter rule for array elements.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 10 2015, 1:38 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 10 2015, 1:40 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/xhpast/rules/ArcanistArrayElementXHPASTLinterRule.php
38 ↗(On Diff #33423)

Maybe check $value->getLineNumber()? Or look at all the nonsemantic tokens? I think this raises a false positive on:

array(
  /* OPEN   */ 1,
  /* CLOSED */ 2,
);

...which is nonstandard in this codebase, but seems reasonable.

This revision is now accepted and ready to land.Aug 10 2015, 1:40 PM
joshuaspence updated this revision to Diff 33456.Aug 10 2015, 9:22 PM
joshuaspence edited edge metadata.

Tidying up

Closed by commit rARC830bcbc2a5e9: Add a linter rule for array elements (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 10 2015, 9:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
lint/
linter/
__tests__/
xhpast/
48 lines
xhpast/
rules/
56 lines

Diff 33457

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/array-value.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistArrayValueXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility