Page MenuHomePhabricator

Add a linter rule for array elements
ClosedPublic

Authored by joshuaspence on Aug 10 2015, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 7:34 AM
Unknown Object (File)
Fri, May 3, 6:54 AM
Unknown Object (File)
Thu, May 2, 4:58 PM
Unknown Object (File)
Thu, Apr 25, 1:19 AM
Unknown Object (File)
Jan 28 2024, 8:04 AM
Unknown Object (File)
Jan 28 2024, 8:04 AM
Unknown Object (File)
Jan 28 2024, 8:03 AM
Unknown Object (File)
Jan 28 2024, 8:03 AM
Subscribers

Details

Summary

Add a linter rule to ensure that array elements occupy a single line each.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for array elements.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/xhpast/rules/ArcanistArrayElementXHPASTLinterRule.php
38 ↗(On Diff #33423)

Maybe check $value->getLineNumber()? Or look at all the nonsemantic tokens? I think this raises a false positive on:

array(
  /* OPEN   */ 1,
  /* CLOSED */ 2,
);

...which is nonstandard in this codebase, but seems reasonable.

This revision is now accepted and ready to land.Aug 10 2015, 1:40 PM
This revision was automatically updated to reflect the committed changes.