Page MenuHomePhabricator
Differential D13805

Add a linter rule for unary postfix expression spacing
ClosedPublic
Actions

Authored by joshuaspence on Aug 6 2015, 12:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 12:42 PM
Unknown Object (File)
Thu, Nov 14, 3:41 AM
Unknown Object (File)
Mon, Nov 11, 5:55 AM
Unknown Object (File)
Mon, Nov 11, 5:55 AM
Unknown Object (File)
Mon, Nov 11, 5:55 AM
Unknown Object (File)
Mon, Nov 11, 5:54 AM
Unknown Object (File)
Sat, Nov 9, 7:41 PM
Unknown Object (File)
Thu, Nov 7, 3:46 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC968f4ae5d73e: Add a linter rule for unary postfix expression spacing
Summary

Unary postfix expressions should not have a space before the operator.

Test Plan

Added test case.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33343.Aug 6 2015, 12:40 AM
joshuaspence retitled this revision from to Add a linter rule for unary postfix expression spacing.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 6 2015, 12:40 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 6 2015, 12:42 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/xhpast/rules/ArcanistUnaryPostfixExpressionSpacingXHPASTLinterRule.php
30

Looks like this is actually testing "preceded", not "followed"?

This revision is now accepted and ready to land.Aug 6 2015, 12:42 AM
joshuaspence updated this revision to Diff 33344.Aug 6 2015, 1:47 AM
joshuaspence edited edge metadata.

Fix linter message

joshuaspence marked an inline comment as done.Aug 6 2015, 1:49 AM
Closed by commit rARC968f4ae5d73e: Add a linter rule for unary postfix expression spacing (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 6 2015, 1:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33345

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/unary-postfix-expression-spacing.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistUnaryPostfixExpressionSpacingXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistUnaryPrefixExpressionSpacingXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility