Page MenuHomePhabricator

Add Projects to Ponder Search View
ClosedPublic

Authored by chad on Aug 5 2015, 4:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 8:24 PM
Unknown Object (File)
Sun, Dec 22, 8:23 PM
Unknown Object (File)
Thu, Dec 12, 2:06 AM
Unknown Object (File)
Sun, Dec 8, 2:00 AM
Unknown Object (File)
Nov 23 2024, 10:28 AM
Unknown Object (File)
Nov 23 2024, 10:28 AM
Unknown Object (File)
Nov 23 2024, 10:19 AM
Unknown Object (File)
Nov 17 2024, 11:58 PM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
T3578: Unbeta Ponder
Commits
Restricted Diffusion Commit
rPfdc1662bfd91: Add Projects to Ponder Search View
Summary

Ref T3578 Allows display of projects if available on individual ponder search results.

Test Plan

Added projects to my questions, see them display on search results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add Projects to Ponder Search View.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3578: Unbeta Ponder.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/ponder/query/PonderQuestionQuery.php
57

Consider needProjectPHIDs for clarity (loading PHIDs vs Project objects)?

src/applications/ponder/query/PonderQuestionSearchEngine.php
69–70

Is there any particular reason for this change? It seems a little inconsistent to make the default include closed/archived questions (defaults generally exclude closed/archived objects in other applications, I think).

src/applications/ponder/storage/PonderQuestion.php
36

Consider projectPHIDs instead of edgeProjectPHIDs for consistency?

This revision is now accepted and ready to land.Aug 5 2015, 4:00 PM
chad marked 2 inline comments as done.Aug 5 2015, 4:14 PM
chad added inline comments.
src/applications/ponder/query/PonderQuestionSearchEngine.php
69–70

This is probably "exploratory". I'm trying to get a better sense of real use of the product. In this what I'm thinking is "all" questions are generally interesting, even if they've been resolved. There are two types of Ponder users, the browsers "I just want to learn" and the helpers "I want to provide answers".

I think "closed" states should expand - "Resolved, Duplicate, Invalid" and an "archive" state should maybe be added. You could outright archive questions that were no longer valid (like an older product version).

Let me back out this change for now and give it some thought.

Yeah, I think "Closed" and "Answered" are maybe not the same. For example, I could imagine a sequence of events like this:

  • User A asks a good question about system X.
  • User B provides a good answer.
  • Someone marks the question as "Has Good Answer" or something.
  • A couple of years later, we stop using X, so the question is now misleading, even though it was a good question at the time.
  • Someone closes the question as "Obsolete" -- but it still has a good answer. Seems like it should be "Has Good Answer, Obsolete", not just "Obsolete"?
chad marked an inline comment as done.Aug 5 2015, 4:25 PM

So ... split out a separate archive or just have lots of different closed states to build queries from?

chad edited edge metadata.
  • Update per feedback
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.

Yeah, I imagine probably replacing the single "Archived" state with a selection of closed states ("Obsolete", "Duplicate", "Invalid", ...) but having all of them mean "This question isn't good for answering or learning from."