Page MenuHomePhabricator
Differential D13791

Add Edit/View Policy to Ponder Questions
ClosedPublic
Actions

Authored by chad on Aug 4 2015, 10:31 PM.
Tags
None
Referenced Files
F15480333: D13791.id33311.diff
Tue, Apr 8, 1:25 PM
F15468013: D13791.id33310.diff
Thu, Apr 3, 7:21 PM
F15467955: D13791.id33309.diff
Thu, Apr 3, 6:44 PM
F15466801: D13791.id.diff
Thu, Apr 3, 9:56 AM
F15463807: D13791.diff
Wed, Apr 2, 3:31 AM
F15414956: D13791.diff
Thu, Mar 20, 3:15 AM
F15397364: D13791.id33310.diff
Sun, Mar 16, 7:47 PM
F15385655: D13791.id33310.diff
Fri, Mar 14, 11:04 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3578: Unbeta Ponder
Commits
Restricted Diffusion Commit
rP135d0c9ee7a6: Add Edit/View Policy to Ponder Questions
Summary

Ref T3578, adds ability to set a default edit and view policy for questions. Not sure what to set viewPolicy to ?

Test Plan

Test an old question, edit policy still on myself. Test a new question, see new default.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33309.Aug 4 2015, 10:31 PM
chad retitled this revision from to Add Edit/View Policy to Ponder Questions.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3578: Unbeta Ponder.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 4 2015, 10:31 PM
epriestley accepted this revision.Aug 4 2015, 10:37 PM
epriestley edited edge metadata.
epriestley added inline comments.
resources/sql/autopatches/20150804.ponder.question.2.sql
2–3

For viewPolicy, just set it to the string 'users' to preserve the old behavior:

...
SET viewPolicy = 'users' WHERE viewPolicy = '';
This revision is now accepted and ready to land.Aug 4 2015, 10:37 PM
chad updated this revision to Diff 33310.Aug 4 2015, 10:40 PM
chad edited edge metadata.
  • add default viewPolicy
Closed by commit rP135d0c9ee7a6: Add Edit/View Policy to Ponder Questions (authored by chad, committed by chad). · Explain WhyAug 4 2015, 10:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33311

View Options

resources/sql/autopatches/20150804.ponder.question.1.sql

Loading...
View Options

resources/sql/autopatches/20150804.ponder.question.2.sql

Loading...
View Options

resources/sql/autopatches/20150804.ponder.question.3.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/ponder/application/PhabricatorPonderApplication.php

Loading...
View Options

src/applications/ponder/capability/PonderQuestionDefaultEditCapability.php

Loading...
View Options

src/applications/ponder/capability/PonderQuestionDefaultViewCapability.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionEditController.php

Loading...
View Options

src/applications/ponder/editor/PonderQuestionEditor.php

Loading...
View Options

src/applications/ponder/storage/PonderQuestion.php

Loading...
Phabricator · Built by Phacility