Differential D13752

[drydock/working-copies] Release leases when working copy operations fail
AbandonedPublic
Actions

Authored by hach-que on Jul 29 2015, 2:22 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T2015: Implement Drydock

Summary

Ref T2015. This makes sure that leases obtained by working copies are automatically released if exceptions occurs.

Test Plan

Not tested.

Diff Detail

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7438
Build 7916: [Placeholder Plan] Wait for 30 Seconds
Build 7915: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	133 ms	PhabricatorCelerityTestCase::Unknown Unit Message ("")
	2,183 ms	PhabricatorLibraryTestCase::Unknown Unit Message ("")
	4 ms	DrydockBlueprintImplementationTestCase::Unknown Unit Message ("")
	8 ms	PhabricatorConduitTestCase::Unknown Unit Message ("")
	1 ms	PhabricatorInfrastructureTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 6 Passed)

Event Timeline

hach-que updated this revision to Diff 33215.Jul 29 2015, 2:22 AM

hach-que retitled this revision from to [drydock/working-copies] Release leases when working copy operations fail.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T2015: Implement Drydock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 29 2015, 2:22 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

• fengyao added a parent revision: D13751: [harbormaster/core] Fix issue where exception during artifact save would result in orphaned lease.Jul 29 2015, 2:29 AM

hach-que removed a parent revision: D13751: [harbormaster/core] Fix issue where exception during artifact save would result in orphaned lease.Jul 29 2015, 2:43 AM

Rebase

I think this is a mixture of stuff that's now handled slightly ahead of HEAD (roughly: when a lease fails, break the lease) and stuff that probably falls under T8153 (roughly: when a lease fails because a resource is bad, break the resource). I think the working copy cache handling falls into the second camp, particularly, if I'm reading it right.

I believe HEAD now has consistent destruction/release behavior.

This revision now requires changes to proceed.Nov 2 2015, 4:46 PM

hach-que abandoned this revision.Dec 3 2015, 8:42 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

blueprint/

DrydockWorkingCopyBlueprintImplementation.php

182 lines

DrydockWorkingCopyCacheBlueprintImplementation.php

50 lines

Diff 33215

View Options

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php