Page MenuHomePhabricator
Differential D13752

[drydock/working-copies] Release leases when working copy operations fail
AbandonedPublic
Actions

Authored by hach-que on Jul 29 2015, 2:22 AM.
Tags
None
Referenced Files
F15397467: D13752.id33215.diff
Sun, Mar 16, 8:23 PM
F15394767: D13752.diff
Sun, Mar 16, 1:02 AM
F15390812: D13752.id.diff
Sat, Mar 15, 6:46 AM
F15334157: D13752.id33792.diff
Sat, Mar 8, 7:08 AM
Unknown Object (File)
Feb 11 2025, 9:46 PM
Unknown Object (File)
Feb 9 2025, 9:38 PM
Unknown Object (File)
Feb 8 2025, 9:48 PM
Unknown Object (File)
Feb 8 2025, 9:48 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Summary

Ref T2015. This makes sure that leases obtained by working copies are automatically released if exceptions occurs.

Test Plan

Not tested.

Diff Detail

Repository
rP Phabricator
Branch
hachque-reconstructed
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 7796
Build 8624: [Placeholder Plan] Wait for 30 Seconds
Build 8623: arc lint + arc unit

Event Timeline

hach-que updated this revision to Diff 33215.Jul 29 2015, 2:22 AM
hach-que retitled this revision from to [drydock/working-copies] Release leases when working copy operations fail.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que added a task: T2015: Implement Drydock.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 29 2015, 2:22 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
• fengyao added a parent revision: D13751: [harbormaster/core] Fix issue where exception during artifact save would result in orphaned lease.Jul 29 2015, 2:29 AM
hach-que removed a parent revision: D13751: [harbormaster/core] Fix issue where exception during artifact save would result in orphaned lease.Jul 29 2015, 2:43 AM
hach-que updated this revision to Diff 33792.Aug 24 2015, 3:02 PM
hach-que edited edge metadata.

Rebase

epriestley edited edge metadata.Oct 1 2015, 3:02 PM

I think this is a mixture of stuff that's now handled slightly ahead of HEAD (roughly: when a lease fails, break the lease) and stuff that probably falls under T8153 (roughly: when a lease fails because a resource is bad, break the resource). I think the working copy cache handling falls into the second camp, particularly, if I'm reading it right.

epriestley requested changes to this revision.Nov 2 2015, 4:46 PM
epriestley edited edge metadata.

I believe HEAD now has consistent destruction/release behavior.

This revision now requires changes to proceed.Nov 2 2015, 4:46 PM
hach-que abandoned this revision.Dec 3 2015, 8:42 AM

Revision Contents
Changeset List

Diff 33792

View Options

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/blueprint/DrydockWorkingCopyCacheBlueprintImplementation.php

Loading...
Phabricator · Built by Phacility