Differential D13743

Remove View Log action from Herald List
ClosedPublic
Actions

Authored by chad on Jul 28 2015, 2:39 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T8979: Herald rule "Edit Log" leads to 404

Commits

Restricted Diffusion Commit
rP62e052f3fc35: Remove View Log action from Herald List

Summary

Fixes T8979. I beleive this explicit page was merged into view, at least I can't find any place to link it now.

Test Plan

View a Herald list, no icon.

Diff Detail

Repository

rP Phabricator

Branch

herald-hist

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7427
Build 7894: [Placeholder Plan] Wait for 30 Seconds
Build 7893: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33197.Jul 28 2015, 2:39 PM

chad retitled this revision from to Remove View Log action from Herald List.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T8979: Herald rule "Edit Log" leads to 404.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 28 2015, 2:39 PM

epriestley accepted this revision.Jul 28 2015, 2:39 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 28 2015, 2:39 PM

Closed by commit rP62e052f3fc35: Remove View Log action from Herald List (authored by chad, committed by chad). · Explain WhyJul 28 2015, 2:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

query/

HeraldRuleSearchEngine.php

6 lines

Diff 33197

View Options

src/applications/herald/query/HeraldRuleSearchEngine.php

Remove View Log action from Herald ListClosedPublicActions