Add tipDirection to PHUIBadgeMiniView
ClosedPublic
Actions

Authored by chad on Jul 26 2015, 9:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 17, 3:46 PM

	Unknown Object (File)
	Sat, Dec 21, 3:56 PM

	Unknown Object (File)
	Dec 13 2024, 8:46 PM

	Unknown Object (File)
	Dec 3 2024, 11:34 AM

	Unknown Object (File)
	Dec 2 2024, 5:25 PM

	Unknown Object (File)
	Nov 28 2024, 4:45 AM

	Unknown Object (File)
	Nov 19 2024, 8:08 PM

	Unknown Object (File)
	Nov 16 2024, 7:55 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP559bcc42c27a: Add tipDirection to PHUIBadgeMiniView

Summary

Makes PHUIBadgeMiniView a little easier to dictate layout. Apply in Timeline.

Test Plan

Tested supercalifragilisticexpialidocious as a badge, saw it align properly.

Diff Detail

Repository

rP Phabricator

Branch

badge-tips

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7411
Build 7862: [Placeholder Plan] Wait for 30 Seconds
Build 7861: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33160.Jul 26 2015, 9:20 PM

chad retitled this revision from to Add tipDirection to PHUIBadgeMiniView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 26 2015, 9:20 PM

epriestley accepted this revision.Jul 27 2015, 2:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 27 2015, 2:36 PM

Closed by commit rP559bcc42c27a: Add tipDirection to PHUIBadgeMiniView (authored by chad, committed by chad). · Explain WhyJul 27 2015, 2:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIBadgeMiniView.php

8 lines

PHUITimelineView.php

1 line

Diff 33160

View Options

src/view/phui/PHUIBadgeMiniView.php