Add tipDirection to PHUIBadgeMiniView
ClosedPublic
Actions

Authored by chad on Jul 26 2015, 9:20 PM.

Tags

None

Referenced Files

	F13381499: D13729.diff
	Sun, Jun 30, 1:52 AM

	F13370583: D13729.id33160.diff
	Thu, Jun 27, 7:04 PM

	F13370110: D13729.id33172.diff
	Thu, Jun 27, 3:29 PM

	F13370002: D13729.id.diff
	Thu, Jun 27, 3:03 PM

	F13369414: D13729.id33160.diff
	Thu, Jun 27, 11:31 AM

	F13369276: D13729.diff
	Thu, Jun 27, 10:40 AM

	F13351847: D13729.diff
	Sun, Jun 23, 10:27 AM

	F13347325: D13729.diff
	Sat, Jun 22, 8:55 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP559bcc42c27a: Add tipDirection to PHUIBadgeMiniView

Summary

Makes PHUIBadgeMiniView a little easier to dictate layout. Apply in Timeline.

Test Plan

Tested supercalifragilisticexpialidocious as a badge, saw it align properly.

Diff Detail

Repository

rP Phabricator

Branch

badge-tips

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7411
Build 7862: [Placeholder Plan] Wait for 30 Seconds
Build 7861: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33160.Jul 26 2015, 9:20 PM

chad retitled this revision from to Add tipDirection to PHUIBadgeMiniView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 26 2015, 9:20 PM

epriestley accepted this revision.Jul 27 2015, 2:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 27 2015, 2:36 PM

Closed by commit rP559bcc42c27a: Add tipDirection to PHUIBadgeMiniView (authored by chad, committed by chad). · Explain WhyJul 27 2015, 2:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIBadgeMiniView.php

8 lines

PHUITimelineView.php

1 line

Diff 33160

View Options

src/view/phui/PHUIBadgeMiniView.php