Add tipDirection to PHUIBadgeMiniView
ClosedPublic
Actions

Authored by chad on Jul 26 2015, 9:20 PM.

Tags

None

Referenced Files

	F14068168: D13729.diff
	Tue, Nov 19, 8:08 PM

	F14055069: D13729.diff
	Sat, Nov 16, 7:55 AM

	F14043477: D13729.diff
	Tue, Nov 12, 10:31 AM

	F14025828: D13729.diff
	Thu, Nov 7, 8:46 PM

	F13986758: D13729.diff
	Oct 21 2024, 5:20 AM

	F13970666: D13729.id33160.diff
	Oct 17 2024, 9:11 AM

	F13964274: D13729.diff
	Oct 15 2024, 8:00 PM

	F13957523: D13729.id.diff
	Oct 14 2024, 9:46 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP559bcc42c27a: Add tipDirection to PHUIBadgeMiniView

Summary

Makes PHUIBadgeMiniView a little easier to dictate layout. Apply in Timeline.

Test Plan

Tested supercalifragilisticexpialidocious as a badge, saw it align properly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33160.Jul 26 2015, 9:20 PM

chad retitled this revision from to Add tipDirection to PHUIBadgeMiniView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 26 2015, 9:20 PM

epriestley accepted this revision.Jul 27 2015, 2:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 27 2015, 2:36 PM

Closed by commit rP559bcc42c27a: Add tipDirection to PHUIBadgeMiniView (authored by chad, committed by chad). · Explain WhyJul 27 2015, 2:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIBadgeMiniView.php

8 lines

PHUITimelineView.php

1 line

Diff 33172

View Options

src/view/phui/PHUIBadgeMiniView.php