Paths

Table of Contentst

Differential D13687

[drydock/core] Show owner link on Drydock leases
AbandonedPublic
Actions

Authored by epriestley on Jul 23 2015, 1:37 AM.

Tags

None

Referenced Files

	F17817199: D13687.diff
	Fri, Jul 25, 11:21 PM

	F17805064: D13687.id33087.diff
	Fri, Jul 25, 12:09 PM

	F17802893: D13687.id.diff
	Fri, Jul 25, 9:36 AM

	F17802699: D13687.diff
	Fri, Jul 25, 9:24 AM

	F17773667: D13687.id33788.diff
	Wed, Jul 23, 5:57 PM

	Unknown Object (File)
	Jun 18 2025, 10:05 PM

	Unknown Object (File)
	May 23 2025, 5:04 AM

	Unknown Object (File)
	May 7 2025, 9:18 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T2015: Implement Drydock

Summary

Ref T2015. Drydock leases have an optional owner PHID which is set by Harbormaster, but it isn't actually show on the interface anywhere. This field is extremely useful for debugging, as it allows users to immediately find out what builds are holding what resources open.

Show the owner handle (if present) on all lease lists and on the lease controller.

Test Plan

Viewed pages, saw the owner handle.

Diff Detail

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7361
Build 7762: [Placeholder Plan] Wait for 30 Seconds
Build 7761: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	521 ms	PhabricatorCelerityTestCase::Unknown Unit Message ("")
	2,702 ms	PhabricatorLibraryTestCase::Unknown Unit Message ("")
	110 ms	HarbormasterAutotargetsTestCase::Unknown Unit Message ("")
	19 ms	PhabricatorConduitTestCase::Unknown Unit Message ("")
	1 ms	PhabricatorInfrastructureTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 6 Passed)

Event Timeline

hach-que updated this revision to Diff 33087.Jul 23 2015, 1:37 AM

hach-que retitled this revision from to [drydock/core] Show owner link on Drydock leases.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T2015: Implement Drydock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 23 2015, 1:37 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Rebase

I think this can be simplified to just $viewer->renderHandleLink($owner_phid) plus an empty state now?

This revision now requires changes to proceed.Sep 23 2015, 6:18 PM

epriestley mentioned this in D14191: Show lease owner in Drydock UI.Sep 29 2015, 2:39 PM

See simpler D14191.

epriestley mentioned this in rP45a5ea7bf504: Show lease owner in Drydock UI.Sep 29 2015, 4:51 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

controller/

DrydockLeaseViewController.php

11 lines

DrydockResourceViewController.php

1 line

query/

DrydockLeaseQuery.php

30 lines

DrydockLeaseSearchEngine.php

1 line

storage/

DrydockLease.php

10 lines

view/

DrydockLeaseListView.php

6 lines

harbormaster/

phid/

HarbormasterBuildTargetPHIDType.php

8 lines

Diff 33087

src/applications/drydock/controller/DrydockLeaseViewController.php

Loading...

src/applications/drydock/controller/DrydockResourceViewController.php

Loading...

src/applications/drydock/query/DrydockLeaseQuery.php

Loading...

src/applications/drydock/query/DrydockLeaseSearchEngine.php

Loading...

src/applications/drydock/storage/DrydockLease.php

Loading...

src/applications/drydock/view/DrydockLeaseListView.php

Loading...

src/applications/harbormaster/phid/HarbormasterBuildTargetPHIDType.php

Loading...