Let's people archive unused Dashboards (if they have permission).
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T6443: Provide ApplicationSearch options for Dashboard
- Commits
- Restricted Diffusion Commit
rPc22d6c7beb08: Add ability to archive a Dashboard
Archive and Unarchive a dashboard, view history, view search, build new filters.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dashboards-search
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7356 Build 7752: [Placeholder Plan] Wait for 30 Seconds Build 7751: arc lint + arc unit
Event Timeline
Comment Actions
Maybe align OPEN/CLOSED and 'open' / 'closed' better with "Archived" / "Active", since we don't have any legacy cruft here?
| src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php | ||
|---|---|---|
| 70–72 | Probably slightly better to set this in initializeNewDashboard(). | |
| src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php | ||
| 25–26 | This method is static, so just call it as PhabricatorDashboard::getStatusNameMap(). | |
| 152 | This is named "Manage", but the UI on this screen has a link to "Manage Dashboard", which takes you to the other place. This is more like "view", and is fully redundant with just clicking the link title. | |
| 161 | This should be disabled if the user doesn't have permission to edit the dhasboard. | |
Comment Actions
- Updates
| src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php | ||
|---|---|---|
| 52 | ahahahaha | |