Page MenuHomePhabricator

Add ability to archive a Dashboard
ClosedPublic

Authored by chad on Jul 22 2015, 10:13 PM.
Tags
None
Referenced Files
F14352654: D13683.id33106.diff
Thu, Dec 19, 2:28 PM
Unknown Object (File)
Sun, Dec 15, 7:52 AM
Unknown Object (File)
Sat, Dec 14, 1:12 AM
Unknown Object (File)
Fri, Dec 13, 2:19 PM
Unknown Object (File)
Fri, Dec 13, 2:57 AM
Unknown Object (File)
Fri, Dec 6, 9:09 PM
Unknown Object (File)
Thu, Dec 5, 6:10 PM
Unknown Object (File)
Sat, Nov 30, 5:30 AM
Subscribers

Details

Summary

Let's people archive unused Dashboards (if they have permission).

Test Plan

Archive and Unarchive a dashboard, view history, view search, build new filters.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add ability to archive a Dashboard.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.

Maybe align OPEN/CLOSED and 'open' / 'closed' better with "Archived" / "Active", since we don't have any legacy cruft here?

src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php
70–72

Probably slightly better to set this in initializeNewDashboard().

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
25–26

This method is static, so just call it as PhabricatorDashboard::getStatusNameMap().

150

This is named "Manage", but the UI on this screen has a link to "Manage Dashboard", which takes you to the other place. This is more like "view", and is fully redundant with just clicking the link title.

159

This should be disabled if the user doesn't have permission to edit the dhasboard.

This revision is now accepted and ready to land.Jul 23 2015, 8:35 PM
chad marked 4 inline comments as done.
chad edited edge metadata.
  • Updates
src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
50

ahahahaha

This revision was automatically updated to reflect the committed changes.