Page MenuHomePhabricator
Differential D13666

Modernize Slowvote Search
ClosedPublic
Actions

Authored by chad on Jul 21 2015, 9:02 PM.
Tags
None
Referenced Files
F14003207: D13666.diff
Sat, Oct 26, 3:28 AM
F13997737: D13666.id.diff
Thu, Oct 24, 5:54 AM
F13994575: D13666.id.diff
Wed, Oct 23, 7:09 AM
F13993242: D13666.id33084.diff
Tue, Oct 22, 9:39 PM
F13970689: D13666.id33082.diff
Oct 17 2024, 9:20 AM
F13964388: D13666.id.diff
Oct 15 2024, 8:10 PM
Unknown Object (File)
Oct 2 2024, 4:26 AM
Unknown Object (File)
Sep 13 2024, 2:25 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP3bfb43629602: Modernize Slowvote Search
Summary

Updates slowvote search forms and results. Note I can't seem to get the Joins clause to fire anymore, is there a modern equiv?

Test Plan

Search on polls by state, votes, author, projects.

Diff Detail

Repository
rP Phabricator
Branch
slowvote-search
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7334
Build 7708: [Placeholder Plan] Wait for 30 Seconds
Build 7707: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33040.Jul 21 2015, 9:02 PM
chad retitled this revision from to Modernize Slowvote Search.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 21 2015, 9:02 PM
epriestley accepted this revision.Jul 22 2015, 8:25 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php
16

I think this is wrong / unnecessary? It will make every query only show stuff you've voted in.

51–55

Or ThreeStateField with "don't care, voted, not voted", although this is a larger change.

This revision is now accepted and ready to land.Jul 22 2015, 8:25 PM
chad planned changes to this revision.Jul 22 2015, 8:34 PM

I'll take a deeper look.

chad added a comment.Jul 22 2015, 8:34 PM

Also, I never got the JOIN clauses to trigger, did I miss something simple?

epriestley added a comment.Jul 22 2015, 9:40 PM

Oh, try implementing buildJoinClauseParts instead of buildJoinsClause?

chad added a comment.Jul 22 2015, 9:41 PM

I tried, but I'll try again. Maybe the other bug was overshadowing my results.

chad added a comment.Jul 22 2015, 11:12 PM

derp, it was Join vs Joins in the method name that sunk me.

chad updated this revision to Diff 33082.Jul 22 2015, 11:13 PM
chad edited edge metadata.
  • Fix Joins
This revision is now accepted and ready to land.Jul 22 2015, 11:13 PM
Closed by commit rP3bfb43629602: Modernize Slowvote Search (authored by chad, committed by chad). · Explain WhyJul 22 2015, 11:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
slowvote/
query/
49 lines
92 lines

Diff 33040

View Options

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
Phabricator · Built by Phacility