Page MenuHomePhabricator
Differential D13666

Modernize Slowvote Search
ClosedPublic
Actions

Authored by chad on Jul 21 2015, 9:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 5:02 AM
Unknown Object (File)
Wed, Dec 4, 1:46 AM
Unknown Object (File)
Tue, Dec 3, 2:03 PM
Unknown Object (File)
Tue, Dec 3, 2:03 PM
Unknown Object (File)
Tue, Dec 3, 2:03 PM
Unknown Object (File)
Tue, Dec 3, 2:02 PM
Unknown Object (File)
Tue, Dec 3, 1:42 PM
Unknown Object (File)
Sun, Dec 1, 1:48 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP3bfb43629602: Modernize Slowvote Search
Summary

Updates slowvote search forms and results. Note I can't seem to get the Joins clause to fire anymore, is there a modern equiv?

Test Plan

Search on polls by state, votes, author, projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33040.Jul 21 2015, 9:02 PM
chad retitled this revision from to Modernize Slowvote Search.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 21 2015, 9:02 PM
epriestley accepted this revision.Jul 22 2015, 8:25 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php
16

I think this is wrong / unnecessary? It will make every query only show stuff you've voted in.

50–54

Or ThreeStateField with "don't care, voted, not voted", although this is a larger change.

This revision is now accepted and ready to land.Jul 22 2015, 8:25 PM
chad planned changes to this revision.Jul 22 2015, 8:34 PM

I'll take a deeper look.

chad added a comment.Jul 22 2015, 8:34 PM

Also, I never got the JOIN clauses to trigger, did I miss something simple?

epriestley added a comment.Jul 22 2015, 9:40 PM

Oh, try implementing buildJoinClauseParts instead of buildJoinsClause?

chad added a comment.Jul 22 2015, 9:41 PM

I tried, but I'll try again. Maybe the other bug was overshadowing my results.

chad added a comment.Jul 22 2015, 11:12 PM

derp, it was Join vs Joins in the method name that sunk me.

chad updated this revision to Diff 33082.Jul 22 2015, 11:13 PM
chad edited edge metadata.
  • Fix Joins
This revision is now accepted and ready to land.Jul 22 2015, 11:13 PM
Closed by commit rP3bfb43629602: Modernize Slowvote Search (authored by chad, committed by chad). · Explain WhyJul 22 2015, 11:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
slowvote/
query/
51 lines
91 lines

Diff 33084

View Options

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
Phabricator · Built by Phacility