Page MenuHomePhabricator

Modularize config modules + add edges, phid modules
ClosedPublic

Authored by epriestley on Jul 21 2015, 12:04 AM.

Details

Summary

Fixes T6859. Adds a readout in /config/ of installed edge and PHID types. See also D13626.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Modularize config modules + add edges, phid modules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad accepted this revision.Jul 21 2015, 12:08 AM
chad edited edge metadata.
chad added inline comments.
src/applications/config/module/PhabricatorConfigEdgeModule.php
45

prefer setTable which applies additional classes.

src/applications/config/module/PhabricatorConfigPHIDModule.php
45

setTable

src/applications/config/module/PhabricatorConfigSiteModule.php
44

setTable

This revision is now accepted and ready to land.Jul 21 2015, 12:08 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jul 21 2015, 12:10 AM

You have 3 Inlines not marked as done, proceed anyways? [y/N]