Page MenuHomePhabricator

Document project tone formally
ClosedPublic

Authored by epriestley on Jul 16 2015, 7:54 PM.

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPef556090f86d: Document project tone formally
Summary

Standards and practices.

Test Plan

Read carefully.

Diff Detail

Repository
rP Phabricator
Branch
tone1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7292
Build 7623: [Placeholder Plan] Wait for 30 Seconds
Build 7622: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Document project tone formally.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Jul 16 2015, 7:56 PM
This revision was automatically updated to reflect the committed changes.

Please Change!

src/docs/user/userguide/tone.diviner
20

This is not good!

42

You should change this!

apexlj added inline comments.
src/docs/user/userguide/tone.diviner
37–40

Hava a try!

Does "leap into action" send draft comments?

src/docs/user/userguide/tone.diviner
44

Test comment.

src/docs/user/userguide/tone.diviner
44

Test reply.

pha_test added inline comments.
src/docs/user/userguide/tone.diviner
11

error ?

tuscan added inline comments.
src/docs/user/userguide/tone.diviner
37–40

k

xgouchet added inline comments.
src/docs/user/userguide/tone.diviner
7

Hello *World* Seems like a nice title

src/docs/user/userguide/tone.diviner
34

test

37–40

sadasdf