Fix Calendar/Double Panel Headers
ClosedPublic
Actions

Authored by chad on Jul 14 2015, 7:31 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8829: Embedded panels have search icon cut off

Commits

Restricted Diffusion Commit
rPa7e33700a060: Fix Calendar/Double Panel Headers

Summary

Fixes T8829. Moves the padding and background to the outer container instead of the table itself.

Test Plan

Test Calendar Month View, Calendar Day View, A Text Panel with Multiple Dashboards.

Diff Detail

Repository

rP Phabricator

Branch

header-table

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7267
Build 7573: [Placeholder Plan] Wait for 30 Seconds
Build 7572: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32937.Jul 14 2015, 7:31 PM

chad retitled this revision from to Fix Calendar/Double Panel Headers.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8829: Embedded panels have search icon cut off.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 14 2015, 7:31 PM

epriestley accepted this revision.Jul 16 2015, 8:42 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 16 2015, 8:42 PM

Closed by commit rPa7e33700a060: Fix Calendar/Double Panel Headers (authored by chad, committed by chad). · Explain WhyJul 17 2015, 12:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-object-box.css

8 lines

Diff 32937

View Options

resources/celerity/map.php