Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T1049: Implement Harbormaster
T8828: Dashboard panel to show build status of containers
Added the dashboard panel on my local Phabricator instance, saw pretty statuses.
Diff Detail
- Repository
- rP Phabricator
- Branch
- hachque-reconstructed
- Lint
Lint Passed Severity Location Code Message Advice src/applications/harbormaster/paneltype/PhabricatorDashboardHarbormasterRepositoryStatusPanelType.php:23 XHP16 TODO Comment Advice src/applications/harbormaster/paneltype/PhabricatorDashboardHarbormasterRepositoryStatusPanelType.php:54 XHP16 TODO Comment - Unit
Tests Skipped - Build Status
Buildable 7801 Build 8634: [Placeholder Plan] Wait for 30 Seconds Build 8633: arc lint + arc unit
Event Timeline
@epriestley I don't suppose there's a chance of getting this upstreamed now that Harbormaster / Drydock is inching closer to being unprototyped?
I think the goal of this panel is a reasonable one, but maybe we can find a better implementation.
For example, suppose we put a build status icon on branches/tags instead, gave them real PHIDs, and put a SearchEngine in front of them? Then you could just build a completely normal Query panel and show exactly the branches you wanted.
I think that would be a slightly different result set than what this panel shows, but mostly accomplishing the same goal?
So I'd do something like:
- Go to Diffusion.
- Click a new "Search Branches" item in the left nav that queries branches across all repositories.
- Narrow that down by typing Exact branches: rP/master, rARC/master, rPHU/master or something, or you could use branch name: master to get all master branches across all repos, or just use the "All Branches Across Everything" default query to approximate what this panel does.
- Save the query.
- Make a panel from it.
And branches could also show build status in Diffusion itself.
We could also reasonably let repositories have the build status of their default branch, I think, in terms of UI presentation? At least for now...
As per @epriestley's feedback, this isn't a good way forward.
With the other search engine and edit engine changes that have been happening, I'm assuming that building the "Search Branches" interface that is described above would be quite complex, so I'm going to leave T10053 as an upstream task.
In the meantime, I plan on building a stand-alone website that uses the Conduit APIs to query the build status across Diffusion repositories so I can still have my build dashboard.