Page MenuHomePhabricator
Differential D13547

Unprototype Spaces
ClosedPublic
Actions

Authored by epriestley on Jul 3 2015, 5:51 PM.
Tags
None
Referenced Files
F14417494: D13547.diff
Wed, Dec 25, 1:26 AM
Unknown Object (File)
Thu, Dec 12, 8:59 AM
Unknown Object (File)
Thu, Dec 12, 5:39 AM
Unknown Object (File)
Fri, Dec 6, 10:30 AM
Unknown Object (File)
Wed, Dec 4, 3:54 AM
Unknown Object (File)
Wed, Dec 4, 3:54 AM
Unknown Object (File)
Wed, Dec 4, 3:54 AM
Unknown Object (File)
Wed, Dec 4, 3:36 AM
View All Files
Subscribers
eadler
epriestley
polybuildr
Tokens
"Doubloon" token, awarded by btrahan."Love" token, awarded by eadler.

Details

Reviewers
btrahan
chad
Maniphest Tasks
T8449: Spaces v1 Errata
Commits
Restricted Diffusion Commit
rPe8a213512aa0: Unprototype Spaces
Summary

Ref T8449. Also, fix annoying inconsistency between "Spaces" and "spaces": "Spaces" is the application, the things it creates are just "spaces", similar to how "Maniphest" creates "tasks".

Test Plan

Mostly reading. Viewed /applications/.

Diff Detail

Repository
rP Phabricator
Branch
space4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7135
Build 7319: [Placeholder Plan] Wait for 30 Seconds
Build 7318: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32729.Jul 3 2015, 5:51 PM
epriestley retitled this revision from to Unprototype Spaces.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T8449: Spaces v1 Errata.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 3 2015, 5:51 PM
eadler awarded a token.Jul 3 2015, 7:41 PM
eadler added a subscriber: eadler.
chad accepted this revision.Jul 3 2015, 7:43 PM
chad edited edge metadata.
chad added inline comments.
src/docs/user/userguide/spaces.diviner
124

This one hurts my head a little.

This revision is now accepted and ready to land.Jul 3 2015, 7:43 PM
btrahan awarded a token.Jul 3 2015, 7:47 PM
epriestley added a comment.Jul 3 2015, 7:49 PM

ssss

Closed by commit rPe8a213512aa0: Unprototype Spaces (authored by epriestley, committed by epriestley). · Explain WhyJul 3 2015, 8:04 PM
This revision was automatically updated to reflect the committed changes.
polybuildr added a subscriber: polybuildr.Nov 13 2015, 9:40 PM
polybuildr added inline comments.
src/docs/user/userguide/spaces.diviner
73

Is the extra 's' at the end of 'spacess' intentional?

Revision Contents
Changeset List

PathSize
src/
applications/
spaces/
application/
6 lines
docs/
user/
userguide/
36 lines

Diff 32729

View Options

src/applications/spaces/application/PhabricatorSpacesApplication.php

Loading...
View Options

src/docs/user/userguide/spaces.diviner

Loading...
Phabricator · Built by Phacility