Page MenuHomePhabricator

Don't put objects into the query workspace by default
ClosedPublic

Authored by epriestley on Jul 1 2015, 6:10 PM.
Tags
None
Referenced Files
F12822139: D13516.id32676.diff
Thu, Mar 28, 7:05 AM
Unknown Object (File)
Sun, Mar 24, 9:20 AM
Unknown Object (File)
Fri, Mar 22, 3:43 AM
Unknown Object (File)
Sun, Mar 10, 2:18 PM
Unknown Object (File)
Feb 25 2024, 11:20 AM
Unknown Object (File)
Feb 9 2024, 2:45 PM
Unknown Object (File)
Feb 3 2024, 5:37 AM
Unknown Object (File)
Feb 2 2024, 10:53 PM
Subscribers

Details

Summary

Ref T8731. I think the issue is that some ProjectQuery (without needImages()) populates the query workspace, then the "real" one hits the workspace.

Instead, only populate the workspace from ObjectQuery, so we know that objects in the workspace always have whatever ObjectQuery attaches to them.

Test Plan

Verified this didn't destroy the cache hitrate, but I can't repro the original issue locally per se.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't put objects into the query workspace by default.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
This revision is now accepted and ready to land.Jul 1 2015, 7:58 PM
This revision was automatically updated to reflect the committed changes.